Shubhendu Tripathi has posted comments on this change. Change subject: gluster: vdsm change for fetching volume capacity info ......................................................................
Patch Set 2: (1 comment) .................................................... File backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/gluster/GlusterVolumeAdvancedDetails.java Line 115: this.capacityInfo = capacityInfo; Line 116: } Line 117: Line 118: @Override Line 119: public int hashCode() { Dont we need entry for brick details as well in hashCode() and equals() method ? Line 120: final int prime = 31; Line 121: int result = 1; Line 122: result = prime * result + ((capacityInfo == null) ? 0 : capacityInfo.hashCode()); Line 123: result = prime * result + ((serviceInfo == null) ? 0 : serviceInfo.hashCode()); -- To view, visit http://gerrit.ovirt.org/23091 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I126eb7057ee1cc9abb31c0a9579c48a5cccb8be0 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Ramesh N <rnach...@redhat.com> Gerrit-Reviewer: Kanagaraj M <kmayi...@redhat.com> Gerrit-Reviewer: Sahina Bose <sab...@redhat.com> Gerrit-Reviewer: Shubhendu Tripathi <shtri...@redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches