Maor Lipchuk has posted comments on this change. Change subject: engine, dao: Introduce ISCSI Bond entity, tables and dao ......................................................................
Patch Set 3: (1 comment) .................................................... File packaging/dbscripts/iscsi_bonds_sp.sql Line 64: DECLARE Line 65: v_val UUID; Line 66: BEGIN Line 67: -- Get (and keep) a shared lock with "right to upgrade to exclusive" Line 68: -- in order to force locking parent before children I don't understand this comment, why do we lock this? Line 69: SELECT id INTO v_val FROM iscsi_bonds WHERE id = v_id FOR UPDATE; Line 70: DELETE FROM iscsi_bonds_networks_map WHERE iscsi_bond_id = v_id; Line 71: DELETE FROM iscsi_bonds WHERE id = v_id; Line 72: END; $procedure$ -- To view, visit http://gerrit.ovirt.org/22951 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I12313c02810a2f0e75016bdd78b44da43f2154d4 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Sergey Gotliv <sgot...@redhat.com> Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipc...@redhat.com> Gerrit-Reviewer: Sergey Gotliv <sgot...@redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
