Lior Vernia has posted comments on this change.
Change subject: webadmin: Add subnet left tab to new network dialog
......................................................................
Patch Set 2:
(1 comment)
....................................................
File
frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/NewNetworkPopupView.java
Line 30: @Override
Line 31: public void updateVisibility() {
Line 32: super.updateVisibility();
Line 33: messageLabel.setVisible(false);
Line 34: toggleSubnetVisibility(exportEditor.asCheckBox().getValue());
I'm pretty sure that it's the event listener you added in
AbstractNetworkPopupPresenterWidget that does that and not this piece of code.
Could you try to get rid of this and verify?
Line 35: }
Line 36:
Line 37: @Override
Line 38: protected void localize(ApplicationConstants constants) {
--
To view, visit http://gerrit.ovirt.org/22690
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I5054c208f692a321d60532046ffa576770c4ec6b
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Mike Kolesnik <mkole...@redhat.com>
Gerrit-Reviewer: Lior Vernia <lver...@redhat.com>
Gerrit-Reviewer: Mike Kolesnik <mkole...@redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
