Lior Vernia has posted comments on this change.
Change subject: webadmin: Add subnet left tab to new network dialog
......................................................................
Patch Set 1:
(3 comments)
....................................................
File
frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/datacenters/NewNetworkModel.java
Line 182: }
Line 183:
Line 184:
Frontend.getInstance().runMultipleAction(VdcActionType.AttachNetworkToVdsGroup,
actionParameters1);
Line 185:
Line 186: if ((Boolean) getExport().getEntity() &&
!getSubnetName().getEntity().isEmpty()) {
That depends on some implementation details of GWT/widget/editor that I'm not
sure about, and that I wouldn't want to count on.
Line 187: ExternalSubnet subnet = new ExternalSubnet();
Line 188: subnet.setName(getSubnetName().getEntity());
Line 189: subnet.setCidr(getSubnetCidr().getEntity());
Line 190:
subnet.setIpVersion(getSubnetIpVersion().getSelectedItem());
Line 183:
Line 184:
Frontend.getInstance().runMultipleAction(VdcActionType.AttachNetworkToVdsGroup,
actionParameters1);
Line 185:
Line 186: if ((Boolean) getExport().getEntity() &&
!getSubnetName().getEntity().isEmpty()) {
Line 187: ExternalSubnet subnet = new ExternalSubnet();
No problem, just a suggestion.
Line 188: subnet.setName(getSubnetName().getEntity());
Line 189: subnet.setCidr(getSubnetCidr().getEntity());
Line 190:
subnet.setIpVersion(getSubnetIpVersion().getSelectedItem());
Line 191:
....................................................
File
frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/datacenter/EditNetworkPopupView.java
Line 45: public void updateVisibility() {
Line 46: super.updateVisibility();
Line 47: attachPanel.setVisible(false);
Line 48: clusterTab.setVisible(false);
Line 49: toggleSubnetVisibility(false);
See comment on that call... If I'm right about that, then the code to be
written could be part of the abstract superclass and obviate the need for this.
Line 50: }
Line 51:
Line 52: @Override
Line 53: public EditNetworkModel flush() {
--
To view, visit http://gerrit.ovirt.org/22690
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I5054c208f692a321d60532046ffa576770c4ec6b
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Mike Kolesnik <mkole...@redhat.com>
Gerrit-Reviewer: Lior Vernia <lver...@redhat.com>
Gerrit-Reviewer: Mike Kolesnik <mkole...@redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
