Lior Vernia has posted comments on this change. Change subject: webadmin: Add subnet left tab to new network dialog ......................................................................
Patch Set 1: NewExternalSubnetModel and the additions to NetworkModel seem to have a lot in common (same fields, same validation), leading me to suggest putting the shared logic in one class (two actually, one for the model and for the view) and reusing it. NewExternalSubnetModel would potentially have the additional field specifying the network, so would extend the common model. A similar thing was done with HostNetworkProviderModel and HostNetworkProviderWidget, you can look at those as reference. -- To view, visit http://gerrit.ovirt.org/22690 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I5054c208f692a321d60532046ffa576770c4ec6b Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Mike Kolesnik <mkole...@redhat.com> Gerrit-Reviewer: Lior Vernia <lver...@redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
