Mike Kolesnik has posted comments on this change. Change subject: core: Add QoS member to Network and VdsNetworkInterface ......................................................................
Patch Set 19: (1 comment) .................................................... File backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/network/InterfaceDaoTest.java Line 165: Line 166: dao.updateInterfaceForVds(iface); Line 167: Line 168: VdsNetworkInterface ifaced = dao.get(interface_id); Line 169: assertTrue(ifaced.getName().equals(iface.getName()) && ifaced.getQos().equals(iface.getQos())); I would use a couple of assert equals since they give better output in case of failure. (Remember that the expected value should be the first one) Line 170: } Line 171: Line 172: /** Line 173: * Ensures updating an interface works, while also updating its previous QoS configuration. -- To view, visit http://gerrit.ovirt.org/22599 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I63776837d41c620258fa53b9a1335b76a5971cea Gerrit-PatchSet: 19 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Lior Vernia <lver...@redhat.com> Gerrit-Reviewer: Eli Mesika <emes...@redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchap...@redhat.com> Gerrit-Reviewer: Lior Vernia <lver...@redhat.com> Gerrit-Reviewer: Mike Kolesnik <mkole...@redhat.com> Gerrit-Reviewer: Moti Asayag <masa...@redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
