Gilad Chaplik has posted comments on this change.
Change subject: core: Add QoS member to Network and VdsNetworkInterface
......................................................................
Patch Set 15:
(3 comments)
....................................................
File
backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/network/VdsNetworkInterface.java
Line 387: .append(getType())
Line 388: .append(", networkImplementationDetails=")
Line 389: .append(getNetworkImplementationDetails())
Line 390: .append(", qos=")
Line 391: .append(getQos())
qos doesn't implement toString()
Line 392: .append(", labels=")
Line 393: .append(getLabels())
Line 394: .append("}");
Line 395: return builder.toString();
....................................................
File
backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/network/InterfaceDaoDbFacadeImpl.java
Line 123: .addValue("bridged", nic.isBridged())
Line 124: .addValue("labels",
SerializationFactory.getSerializer().serialize(nic.getLabels()));
Line 125: }
Line 126:
Line 127: private void persistQosChanges(VdsNetworkInterface entity) {
I may be wrong but I think that this logic should reside in bll.
Line 128: NetworkQoSDao qosDao = DbFacade.getInstance().getQosDao();
Line 129: Guid id = entity.getId();
Line 130: NetworkQoS oldQos = qosDao.get(id);
Line 131: NetworkQoS qos = entity.getQos();
....................................................
File packaging/dbscripts/upgrade/03_04_0330_add_qos_id_to_network.sql
Line 1: SELECT fn_db_add_column('network', 'qos_id', 'UUID');
Line 2: SELECT fn_db_create_constraint('network', 'fk_network_qos_id', 'FOREIGN
KEY (qos_id) REFERENCES network_qos(id) ON DELETE SET NULL');
I'd add the the constraint to the add_col func. more efficient, and IMO more
readable.
--
To view, visit http://gerrit.ovirt.org/22599
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I63776837d41c620258fa53b9a1335b76a5971cea
Gerrit-PatchSet: 15
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Lior Vernia <lver...@redhat.com>
Gerrit-Reviewer: Gilad Chaplik <gchap...@redhat.com>
Gerrit-Reviewer: Lior Vernia <lver...@redhat.com>
Gerrit-Reviewer: Mike Kolesnik <mkole...@redhat.com>
Gerrit-Reviewer: Moti Asayag <masa...@redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
