Lior Vernia has posted comments on this change.
Change subject: core: Add QoS member to Network and VdsNetworkInterface
......................................................................
Patch Set 15:
(4 comments)
....................................................
File
backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/network/InterfaceDaoDbFacadeImpl.java
Line 252: entity.setId(getGuidDefaultEmpty(rs, "id"));
Line 253:
entity.setBootProtocol(NetworkBootProtocol.forValue(rs.getInt("boot_protocol")));
Line 254: entity.setMtu(rs.getInt("mtu"));
Line 255: entity.setBridged(rs.getBoolean("bridged"));
Line 256:
entity.setQos(DbFacade.getInstance().getQosDao().get(getGuid(rs, "id")));
Done
Line 257:
entity.setLabels(SerializationFactory.getDeserializer().deserialize(rs.getString("labels"),
Line 258: HashSet.class));
Line 259: return entity;
Line 260: }
....................................................
File
backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/network/InterfaceDaoTest.java
Line 97: List<VdsNetworkInterface> result =
dao.getAllInterfacesForVds(VDS_ID);
Line 98: boolean found = false;
Line 99:
Line 100: for (VdsNetworkInterface iface : result) {
Line 101: found |= iface.getName()
Done
Line 102: .equals(newVdsInterface.getName());
Line 103: }
Line 104:
Line 105: assertTrue(found);
Line 161: @Test
Line 162: public void testUpdateInterfaceForVds() {
Line 163: List<VdsNetworkInterface> before =
dao.getAllInterfacesForVds(VDS_ID);
Line 164: VdsNetworkInterface iface = before.get(0);
Line 165:
Done
Line 166: iface.setName(iface.getName().toUpperCase());
Line 167:
Line 168: dao.updateInterfaceForVds(iface);
Line 169:
....................................................
File packaging/dbscripts/upgrade/03_04_0330_add_qos_id_to_network.sql
Line 1: SELECT fn_db_add_column('network', 'qos_id', 'UUID');
Line 2: SELECT fn_db_create_constraint('network', 'fk_network_qos_id', 'FOREIGN
KEY (qos_id) REFERENCES network_qos(id) ON DELETE SET NULL');
Since Eli acked and I'm lazy, no hard feelings if I don't change it? :)
--
To view, visit http://gerrit.ovirt.org/22599
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I63776837d41c620258fa53b9a1335b76a5971cea
Gerrit-PatchSet: 15
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Lior Vernia <lver...@redhat.com>
Gerrit-Reviewer: Eli Mesika <emes...@redhat.com>
Gerrit-Reviewer: Gilad Chaplik <gchap...@redhat.com>
Gerrit-Reviewer: Lior Vernia <lver...@redhat.com>
Gerrit-Reviewer: Mike Kolesnik <mkole...@redhat.com>
Gerrit-Reviewer: Moti Asayag <masa...@redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
