Arik Hadas has posted comments on this change. Change subject: core: cleanup in RunVmCommand ......................................................................
Patch Set 3: (1 comment) .................................................... Commit Message Line 12: separate methods Line 13: - Change logs to more standard way Line 14: - Add static final String member that contains stateless snapshot Line 15: description instead of having explicit string inside the code Line 16: - This patch also contains trivial refactoring in VmPoolMonitor I tend to agree because IMO it would make the patch easier to review, but in this area in the code the review process is slow (which is understandable since most of the patches are reviewed by one maintainer that has a lot of additional work as well). so if I want this to be merged soon, I need to combine it.. Line 17: Line 18: Change-Id: I95c423151b2cdb36d5bd50c635439bea2cec816c -- To view, visit http://gerrit.ovirt.org/22391 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I95c423151b2cdb36d5bd50c635439bea2cec816c Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Arik Hadas <aha...@redhat.com> Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com> Gerrit-Reviewer: Arik Hadas <aha...@redhat.com> Gerrit-Reviewer: Omer Frenkel <ofren...@redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
