Arik Hadas has posted comments on this change. Change subject: core: cleanup in RunVmCommand ......................................................................
Patch Set 3: Allon, you're raising a valid concern about the need for tests to prevent regressions. The risky parts of this patch are the changes in the logs & extraction of code to separate methods which will be hard to test by unit tests anyway. This patch was made as part of the implementation for a solution for bz #1039507, so while verifying it I reproduced every flow that is affected by this patch manually and it all worked well -- To view, visit http://gerrit.ovirt.org/22391 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I95c423151b2cdb36d5bd50c635439bea2cec816c Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Arik Hadas <aha...@redhat.com> Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com> Gerrit-Reviewer: Arik Hadas <aha...@redhat.com> Gerrit-Reviewer: Omer Frenkel <ofren...@redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
