Omer Frenkel has submitted this change and it was merged. Change subject: core: cleanup in RunVmCommand ......................................................................
core: cleanup in RunVmCommand - Extract code sections that initialize command context for child commands to separate methods - Extract code sections that initialize parameters for child commands to separate methods - Change logs to more standard way - Add static final String member that contains stateless snapshot description instead of having explicit string inside the code - This patch also contains trivial refactoring in VmPoolMonitor Change-Id: I95c423151b2cdb36d5bd50c635439bea2cec816c Signed-off-by: Arik Hadas <aha...@redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RunVmCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VmPoolMonitor.java 2 files changed, 74 insertions(+), 68 deletions(-) Approvals: Omer Frenkel: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/22391 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I95c423151b2cdb36d5bd50c635439bea2cec816c Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Arik Hadas <aha...@redhat.com> Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com> Gerrit-Reviewer: Arik Hadas <aha...@redhat.com> Gerrit-Reviewer: Omer Frenkel <ofren...@redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
