Shireesh Anjal has posted comments on this change. Change subject: restapi: Mappers for Gluster entities ......................................................................
Patch Set 2: (11 inline comments) .................................................... File backend/manager/modules/restapi/types/src/main/java/org/ovirt/engine/api/restapi/types/GlusterBrickMapper.java Line 8: Since we have now modelled bricks as entities, I guess this should be ok? Line 22: brick.setStatus(GlusterBrickStatus.valueOf(fromBrick.getStatus().name())); 1) Guid.createGuidFromString handles null input and won't throw NPE. However I do get the point, and will add null checks before referencing any field. 2) Will do. 3) Understood. Will do. Line 31: brick.setStatus(GlusterStatus.valueOf(fromBrick.getStatus().name())); Done .................................................... File backend/manager/modules/restapi/types/src/main/java/org/ovirt/engine/api/restapi/types/GlusterOptionMapper.java Line 6: Guess this should be ok, now that we are treating options as entities. Line 13: return option; Done Line 21: return option; Done .................................................... File backend/manager/modules/restapi/types/src/main/java/org/ovirt/engine/api/restapi/types/GlusterVolumeMapper.java Line 54: } Done Line 58: Done Line 90: return volume; Done .................................................... File backend/manager/modules/restapi/types/src/test/java/org/ovirt/engine/api/restapi/types/GlusterBrickMapperTest.java Line 23: assertEquals(model.getStatus(), transform.getStatus()); Done .................................................... File backend/manager/modules/restapi/types/src/test/java/org/ovirt/engine/api/restapi/types/GlusterVolumeMapperTest.java Line 82: } Done -- To view, visit http://gerrit.ovirt.org/3385 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I364d853106eda1a956241eb7210ce85781ee88b9 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Shireesh Anjal <san...@redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchap...@redhat.com> Gerrit-Reviewer: Livnat Peer <lp...@redhat.com> Gerrit-Reviewer: Michael Pasternak <mpast...@redhat.com> Gerrit-Reviewer: Omer Frenkel <ofren...@redhat.com> Gerrit-Reviewer: Ori Liel <ol...@redhat.com> Gerrit-Reviewer: Shireesh Anjal <san...@redhat.com> _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
