Shireesh Anjal has posted comments on this change. Change subject: restapi: Mappers for Gluster entities ......................................................................
Patch Set 8: (8 inline comments) Responses inline. .................................................... File backend/manager/modules/compat/src/main/java/org/ovirt/engine/core/compat/StringHelper.java Line 247: } Done .................................................... File backend/manager/modules/compat/src/test/java/org/ovirt/engine/core/compat/StringHelperTest.java Line 35: } Done .................................................... File backend/manager/modules/restapi/types/src/main/java/org/ovirt/engine/api/restapi/types/GlusterVolumeMapper.java Line 51: OK. Will remove mapping of options. Bricks, however, must remain in the REST-to-BLL mapping as there is no way to create a volume without bricks. Line 58: volume.addTransportType(TransportType.TCP); Will remove any code that sets default values in REST layer. Line 68: Done Line 79: It is not possible to create a volume without bricks. Hence we must accept bricks in the "create volume" api. Hence the mapping is also required here. Line 135: I can remove the bricks mapping in this case (BLL-to-REST). However in that case the output of GET request will look inconsistent from the representation accepted in the POST request (which contains bricks). What would you suggest? Line 146: } Done -- To view, visit http://gerrit.ovirt.org/3385 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I364d853106eda1a956241eb7210ce85781ee88b9 Gerrit-PatchSet: 8 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Shireesh Anjal <san...@redhat.com> Gerrit-Reviewer: Eoghan Glynn <eoghan.gl...@gmail.com> Gerrit-Reviewer: Gilad Chaplik <gchap...@redhat.com> Gerrit-Reviewer: Livnat Peer <lp...@redhat.com> Gerrit-Reviewer: Michael Pasternak <mpast...@redhat.com> Gerrit-Reviewer: Omer Frenkel <ofren...@redhat.com> Gerrit-Reviewer: Ori Liel <ol...@redhat.com> Gerrit-Reviewer: Shireesh Anjal <san...@redhat.com> _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
