Juan Hernandez has posted comments on this change. Change subject: restapi: RSDL metadata for gluster related REST api ......................................................................
Patch Set 5: Why use the "gluster" prefix for everything? I think that the RESTAPI should not include this prefix. For example, if I am looking fro the volumes into a given cluster the URL should be (in my opininon) something like "/api/cluster/aaaaa.../volumes" instead of "/api/cluster/aaaaaa.../glustervolumes". If there is a need to differentiate with other types of volumes that should be an attribute of the volume itself. Appart from that the additions look in line with the rest of the existing RDSL metadata. Is this change standalone? I mean, can it be applied without the corresponding changes to the .xsd and to the Java code? I think it can't. I would suggest to merge this change with the changes to the .xsd and Java code. -- To view, visit http://gerrit.ovirt.org/3918 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I2883e452b8f6bc4b51bd2199fbd712f56dd96ab5 Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Shireesh Anjal <san...@redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchap...@redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernan...@redhat.com> Gerrit-Reviewer: Livnat Peer <lp...@redhat.com> Gerrit-Reviewer: Omer Frenkel <ofren...@redhat.com> Gerrit-Reviewer: Ori Liel <ol...@redhat.com> Gerrit-Reviewer: Shireesh Anjal <san...@redhat.com> _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
