Allon Mureinik has posted comments on this change.
Change subject: core: Verifying storage space for AddDiskCommand
......................................................................
Patch Set 4:
(1 comment)
Minor comment about threshold validations.
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddDiskCommand.java
Line 232: return getParameters().getVmId() == null ||
Guid.Empty.equals(getParameters().getVmId()) || super.isVmExist();
Line 233: }
Line 234:
Line 235: protected boolean validateStorageDomainWithinThresholds() {
Line 236: if (getDiskImageInfo().getVolumeType() != VolumeType.Sparse){
Actually, I'd do this validation regardless.
We leave ourselves some free space in the domain so we can later manipulate
other images - it has nothing to do with the newly added image's format.
(and yes, I know your code doesn't introduce it, but this is the opportunity to
fix it, once we're touching validations.)
Line 237: return
validate(getStorageDomainValidator().isDomainWithinThresholds());
Line 238: }
Line 239: return true;
Line 240: }
--
To view, visit http://gerrit.ovirt.org/15377
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I1a33502683ec77fba09efffba1438beb552082f7
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Vered Volansky <vvola...@redhat.com>
Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com>
Gerrit-Reviewer: Daniel Erez <de...@redhat.com>
Gerrit-Reviewer: Liron Ar <lara...@redhat.com>
Gerrit-Reviewer: Sergey Gotliv <sgot...@redhat.com>
Gerrit-Reviewer: Tal Nisan <tni...@redhat.com>
Gerrit-Reviewer: Vered Volansky <vvola...@redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
