Sergey Gotliv has posted comments on this change.
Change subject: core: Verifying storage space for AddDiskCommand
......................................................................
Patch Set 2:
(1 comment)
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/validator/StorageDomainValidator.java
Line 87:
Line 88: for (DiskImage diskImage : diskImages) {
Line 89: double diskCapacity = diskImage.getSize();
Line 90: double sizeForDisk = diskCapacity;
Line 91:
You probably don't need 2 variables here.
Line 92: if (diskImage.getVolumeFormat() == VolumeFormat.COW) {
Line 93: if (storageDomain.getStorageType().isFileDomain()) {
Line 94: sizeForDisk = EMPTY_QCOW_HEADER_SIZE;
Line 95: } else {
--
To view, visit http://gerrit.ovirt.org/15377
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I1a33502683ec77fba09efffba1438beb552082f7
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Vered Volansky <vvola...@redhat.com>
Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com>
Gerrit-Reviewer: Daniel Erez <de...@redhat.com>
Gerrit-Reviewer: Liron Ar <lara...@redhat.com>
Gerrit-Reviewer: Sergey Gotliv <sgot...@redhat.com>
Gerrit-Reviewer: Tal Nisan <tni...@redhat.com>
Gerrit-Reviewer: Vered Volansky <vvola...@redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
