Omer Frenkel has submitted this change and it was merged. Change subject: engine: Create Gluster Volume enhancements ......................................................................
engine: Create Gluster Volume enhancements Modified CreateGlusterVolumeCommand to - Disable NFS on the volume if it is not passed as one of the access protocols - Set the UUID of newly created volume as return value - Add error in "executionFailedMessages" in case VDS command fails Introduced new class AbstractGlusterBrokerCommand, which will now be the base class of all Gluster related VDS commands, and will handle situations where the gluster command fails on VDSM. Removed unnecessary code (setting options) from CreateGlusterVolumeVDSCommand as it is being already taken care in CreateGlusterVolumeCommand Change-Id: I1635511a3daa3503f13724a58556fc5a83d01ec8 Signed-off-by: Shireesh Anjal <san...@redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/CreateGlusterVolumeCommand.java A backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/gluster/AbstractGlusterBrokerCommand.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/gluster/CreateGlusterVolumeVDSCommand.java 3 files changed, 58 insertions(+), 28 deletions(-) Approvals: Shireesh Anjal: Verified Omer Frenkel: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/3921 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I1635511a3daa3503f13724a58556fc5a83d01ec8 Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Shireesh Anjal <san...@redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchap...@redhat.com> Gerrit-Reviewer: Livnat Peer <lp...@redhat.com> Gerrit-Reviewer: Omer Frenkel <ofren...@redhat.com> Gerrit-Reviewer: Shireesh Anjal <san...@redhat.com> _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
