Shireesh Anjal has posted comments on this change.
Change subject: engine: Create Gluster Volume enhancements
......................................................................
Patch Set 3:
The following code immediately after executing the VDS command should make sure
that the volume doesn't get inserted in case the VDS command had failed:
if(!getSucceeded()) {
getReturnValue().getExecuteFailedMessages().add(returnValue.getVdsError().getMessage());
return;
}
The code to insert the volume in DB (addVolumeToDb) comes after the above piece
of code, and hence it won't be executed in case of VDS command failure.
--
To view, visit http://gerrit.ovirt.org/3921
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I1635511a3daa3503f13724a58556fc5a83d01ec8
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Shireesh Anjal <san...@redhat.com>
Gerrit-Reviewer: Gilad Chaplik <gchap...@redhat.com>
Gerrit-Reviewer: Livnat Peer <lp...@redhat.com>
Gerrit-Reviewer: Omer Frenkel <ofren...@redhat.com>
Gerrit-Reviewer: Shireesh Anjal <san...@redhat.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
