Omer Frenkel has posted comments on this change. Change subject: engine: Create Gluster Volume enhancements ......................................................................
Patch Set 3: after this change, if CreateGlusterVolumeVDSCommand will fail, it will not throw exception, so the execution flow of CreateGlusterVolumeCommand will not break, and in case of error, the volume will still be added to the db (since CreateGlusterVolumeCommand is marked with @NonTransactiveCommandAttribute) i guess this is not the desired behavior. -- To view, visit http://gerrit.ovirt.org/3921 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I1635511a3daa3503f13724a58556fc5a83d01ec8 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Shireesh Anjal <san...@redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchap...@redhat.com> Gerrit-Reviewer: Livnat Peer <lp...@redhat.com> Gerrit-Reviewer: Omer Frenkel <ofren...@redhat.com> Gerrit-Reviewer: Shireesh Anjal <san...@redhat.com> _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
