Alon Bar-Lev has posted comments on this change. Change subject: packaging: setup: update firewall for all services ......................................................................
Patch Set 15: (1 comment) .................................................... File packaging/setup/ovirt_engine_setup/firewall_manager_base.py Line 19: from otopi import util Line 20: Line 21: Line 22: @util.export Line 23: class FirewallManagerBase(object): if you want to expose this now we need to maintain it later, I am unsure we want to expose this as service in this version. all plugins are equal, if you expose it now, it means that you need to add firewalld and iptables as own modules to register and not having them within the manager code. Line 24: Line 25: def __init__(self, plugin): Line 26: self._plugin = plugin Line 27: -- To view, visit http://gerrit.ovirt.org/20737 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: If3c1a634b2e8539ebd604205b5487290c8d8a1a9 Gerrit-PatchSet: 15 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yedidyah Bar David <d...@redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alo...@redhat.com> Gerrit-Reviewer: Ofer Schreiber <oschr...@redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbona...@redhat.com> Gerrit-Reviewer: Yedidyah Bar David <d...@redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
