Yedidyah Bar David has posted comments on this change. Change subject: packaging: setup: update firewall for all services ......................................................................
Patch Set 13: (2 comments) .................................................... File packaging/setup/plugins/ovirt-engine-setup/network/firewall_manager.py Line 170: ) Line 171: Line 172: if ( Line 173: self.environment[osetupcons.ConfigEnv.UPDATE_FIREWALL] is None and Line 174: len(self._detected_managers) > 0 I can't see how to fulfill both this and your earlier comment here which says to set it to False if there are no managers, and with your comment saying these things need to be checked at validation. Line 175: ): Line 176: self.dialog.note( Line 177: text=_( Line 178: 'Setup can automatically configure the firewall ' Line 258: osetupcons.ConfigEnv.FIREWALL_MANAGER Line 259: ] = manager Line 260: break Line 261: Line 262: self.environment[otopicons.NetEnv.IPTABLES_ENABLE] = ( I do not think I'll have time for this today. Please open a bug if you want. As I said, I am certain there are other case, perhaps more complex. Line 263: self.environment[ Line 264: osetupcons.ConfigEnv.FIREWALL_MANAGER Line 265: ] == osetupcons.Const.FIREWALL_MANAGER_IPTABLES Line 266: ) -- To view, visit http://gerrit.ovirt.org/20737 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: If3c1a634b2e8539ebd604205b5487290c8d8a1a9 Gerrit-PatchSet: 13 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yedidyah Bar David <d...@redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alo...@redhat.com> Gerrit-Reviewer: Ofer Schreiber <oschr...@redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbona...@redhat.com> Gerrit-Reviewer: Yedidyah Bar David <d...@redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
