Sandro Bonazzola has posted comments on this change. Change subject: packaging: setup: update firewall for all services ......................................................................
Patch Set 13: (2 comments) .................................................... File packaging/setup/plugins/ovirt-engine-setup/network/firewall_manager.py Line 162: self._detected_managers.append(manager) Line 163: Line 164: if (osetupcons.Const.FIREWALL_MANAGER_FIREWALLD in Line 165: self._detected_managers and Line 166: not self.environment[otopicons.NetEnv.FIREWALLD_AVAILABLE] I like the managers modeling with these classes. Line 167: ): Line 168: self._detected_managers.remove( Line 169: osetupcons.Const.FIREWALL_MANAGER_FIREWALLD Line 170: ) Line 258: osetupcons.ConfigEnv.FIREWALL_MANAGER Line 259: ] = manager Line 260: break Line 261: Line 262: self.environment[otopicons.NetEnv.IPTABLES_ENABLE] = ( > Do you think we should abort here? Warn? Let's issue at least a warning. The admin will see it and may re-run setup with the correct value or reinstall the correct firewall. Line 263: self.environment[ Line 264: osetupcons.ConfigEnv.FIREWALL_MANAGER Line 265: ] == osetupcons.Const.FIREWALL_MANAGER_IPTABLES Line 266: ) -- To view, visit http://gerrit.ovirt.org/20737 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: If3c1a634b2e8539ebd604205b5487290c8d8a1a9 Gerrit-PatchSet: 13 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yedidyah Bar David <d...@redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alo...@redhat.com> Gerrit-Reviewer: Ofer Schreiber <oschr...@redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbona...@redhat.com> Gerrit-Reviewer: Yedidyah Bar David <d...@redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
