Mike Kolesnik has posted comments on this change. Change subject: core : Moving retrieve of all disk for vm query from vm_images_view to all_disks view ......................................................................
Patch Set 2: (3 inline comments) .................................................... File backend/manager/dbscripts/create_views.sql Line 164: WHERE images_storage_domain_view.active = TRUE minor: you don't have to write the view name since its the only view we select from anyway .................................................... File backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/itests/BasicTestSetup.java Line 422: DB_FACADE.getDiskDao().removeAllForVmId(vm.getId()); Shouldn't this line be removed? .................................................... File backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/DiskDaoTest.java Line 79: assertTrue(result.isEmpty()); Why changed from asserting that it is not empty? -- To view, visit http://gerrit.ovirt.org/3865 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I75254e1e213fbe29fee53fc25d627b3d5c016768 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Michael Kublin <mkub...@redhat.com> Gerrit-Reviewer: Michael Kublin <mkub...@redhat.com> Gerrit-Reviewer: Mike Kolesnik <mkole...@redhat.com> _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
