Mike Kolesnik has posted comments on this change.
Change subject: core : Moving retrieve of all disk for vm query from
vm_images_view to all_disks view
......................................................................
Patch Set 1: (7 inline comments)
....................................................
File backend/manager/dbscripts/all_disks_sp.sql
Line 32: WHERE image_group_id = v_disk_id AND active = TRUE;
Why do we need this active = TRUE here?
It should be in the all_disks view.
Line 37: Create or replace FUNCTION GetImagesByVmGuid(v_vm_guid UUID, v_user_id
UUID, v_is_filtered BOOLEAN)
Should be called Get[Disks]ByVmGuid or something similar
Line 44: vm_guid = v_vm_guid AND active = TRUE
(same comment about active)
Line 46: FROM user_vm_permissions_view
If disk is floating, shouldn't we check for disk permission level?
Or user portal can't see floating disks?
....................................................
File backend/manager/dbscripts/create_views.sql
Line 163: FROM images_storage_domain_view
The active = TRUE should be here (in WHERE clause, of course)
....................................................
File
backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/DiskDaoDbFacadeImpl.java
Line 38: public void removeAllForVmId(Guid id) {
This method is only being used in BasicTestSetup.removeVM(), can you please
move it there?
....................................................
File
backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/DiskDao.java
Line 8: public interface DiskDao extends ReadDao<Disk, Guid> {
Please fix javadoc to not refer to images
--
To view, visit http://gerrit.ovirt.org/3865
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I75254e1e213fbe29fee53fc25d627b3d5c016768
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Michael Kublin <mkub...@redhat.com>
Gerrit-Reviewer: Mike Kolesnik <mkole...@redhat.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
