Michael Kublin has posted comments on this change.

Change subject: core : Moving retrieve of all disk for vm query from 
vm_images_view to all_disks view
......................................................................


Patch Set 1: (4 inline comments)

....................................................
File backend/manager/dbscripts/all_disks_sp.sql
Line 32:     WHERE  image_group_id = v_disk_id AND active = TRUE;
Done

Line 37: Create or replace FUNCTION GetImagesByVmGuid(v_vm_guid UUID, v_user_id 
UUID, v_is_filtered BOOLEAN)
Done

Line 46:                                         FROM   user_vm_permissions_view
the patch is not related to floating feature

....................................................
File 
backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/DiskDaoDbFacadeImpl.java
Line 38:     public void removeAllForVmId(Guid id) {
sure

--
To view, visit http://gerrit.ovirt.org/3865
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I75254e1e213fbe29fee53fc25d627b3d5c016768
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Michael Kublin <mkub...@redhat.com>
Gerrit-Reviewer: Michael Kublin <mkub...@redhat.com>
Gerrit-Reviewer: Mike Kolesnik <mkole...@redhat.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to