Yedidyah Bar David has posted comments on this change.
Change subject: packaging: setup: Always enable postgres and websocket
......................................................................
Patch Set 1:
> websocket proxy should not be enabled even if configured as it is always
> configured but not necessary is used on engine machine.
Why do you think it's always configured? This is an option. If admin replies
"no" during setup it's not configured.
> postgres - what happens if I install using local database then use the
> backup/restore to move it remotely. will from now on I need to manually
> disable postgres start after each upgrade?
No - the code in this change enables it if:
condition=lambda self: (
self.environment[osetupcons.DBEnv.HOST] == 'localhost'
)
engine-backup --mode=restore --change-db-credentials rewrites
10-setup-database.conf to have ENGINE_DB_HOST=newhost and so on the next run of
engine-setup self.environment[osetupcons.DBEnv.HOST] will be 'newhost'.
--
To view, visit http://gerrit.ovirt.org/20736
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I341eb3fbd64b904da502b293de52770e951417d2
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Yedidyah Bar David <d...@redhat.com>
Gerrit-Reviewer: Alon Bar-Lev <alo...@redhat.com>
Gerrit-Reviewer: Ofer Schreiber <oschr...@redhat.com>
Gerrit-Reviewer: Sandro Bonazzola <sbona...@redhat.com>
Gerrit-Reviewer: Yedidyah Bar David <d...@redhat.com>
Gerrit-HasComments: No
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
