Alon Bar-Lev has posted comments on this change. Change subject: packaging: setup: Always enable postgres and websocket ......................................................................
Patch Set 1: Last comment of mine in this thread. We should not play with services startup state during an upgrade. Auto enable service during setup is by it-self kind of violation, probably we need to ask user if he wish us to auto start the required service. We did not do this because I did not want to open a new front with PM/QA, maybe that was a mistake. But on update we should not touch service startup state unless it is part of upgrade, for example we split engine into two services, initial service is marked to be started at boot, so we mark both to be started. -- To view, visit http://gerrit.ovirt.org/20736 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I341eb3fbd64b904da502b293de52770e951417d2 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yedidyah Bar David <d...@redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alo...@redhat.com> Gerrit-Reviewer: Ofer Schreiber <oschr...@redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbona...@redhat.com> Gerrit-Reviewer: Yedidyah Bar David <d...@redhat.com> Gerrit-HasComments: No _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
