Cheryn Tan has posted comments on this change.

Change subject: core: Storage activation error fix
......................................................................


Patch Set 5:

(1 comment)

I wonder if we can change "handle Storage Domain" to something more specific 
and helpful. Suggestions inline.

....................................................
File 
frontend/webadmin/modules/userportal-gwtp/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties
Line 404: ACTION_TYPE_FAILED_CANNOT_CHANGE_STORAGE_DOMAIN_TYPE=Cannot ${action} 
${type}. Cannot change Storage Domain type.
Line 405: ACTION_TYPE_FAILED_STORAGE_DOMAIN_STATUS_ILLEGAL=Cannot ${action} 
${type}. The relevant Storage Domain is inaccessible.\n\
Line 406:       -Please handle Storage Domain issues and retry the operation.
Line 407: ACTION_TYPE_FAILED_STORAGE_DOMAIN_STATUS_ILLEGAL2=Cannot ${action} 
${type}. The relevant Storage Domain's status is ${status}.\n\
Line 408:       -Please handle Storage Domain and retry the operation.
Can you please clarify what "handle Storage Domain" means? Can we change it to 
something a bit more specific, like "activate the storage domain" or "reattach 
the storage domain to the data centre" or something? Or are there too many 
possibilities?
Line 409: STORAGE_POOL_REINITIALIZE_WITH_MORE_THAN_ONE_DATA_DOMAIN = Cannot 
${action} ${type}.\n\
Line 410: The ${action} action can be performed on a Data Center that has only 
one Storage Domain in Active/Unknown state.
Line 411: ACTION_TYPE_FAILED_STORAGE_POOL_NOT_EXIST= Data Center doesn't exist.
Line 412: ACTION_TYPE_FAILED_STORAGE_DOMAIN_NOT_IN_STORAGE_POOL=Cannot 
${action} ${type}. The selected Storage Domain is not part of the Data Center.


-- 
To view, visit http://gerrit.ovirt.org/21320
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ibe8ad96a5bd40adb56b7a63c4ae5ef75a550e5b2
Gerrit-PatchSet: 5
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Vered Volansky <vvola...@redhat.com>
Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com>
Gerrit-Reviewer: Cheryn Tan <cheryn...@redhat.com>
Gerrit-Reviewer: Daniel Erez <de...@redhat.com>
Gerrit-Reviewer: Liron Ar <lara...@redhat.com>
Gerrit-Reviewer: Michael Pasternak <mpast...@redhat.com>
Gerrit-Reviewer: Sergey Gotliv <sgot...@redhat.com>
Gerrit-Reviewer: Vered Volansky <vvola...@redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to