Vered Volansky has posted comments on this change.
Change subject: core: Storage activation error fix
......................................................................
Patch Set 6: Verified+1
(2 comments)
Liron, Test was checked and is fine.
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/StorageDomainCommandBase.java
Line 172: return valid;
Line 173: }
Line 174:
Line 175: protected boolean
checkStorageDomainStatusNotEqual(StorageDomainStatus status) {
Line 176: if (getStorageDomainStatus() != null &&
getStorageDomainStatus() != status) {
This would change the logic of this if.
If you are sure there's no chance of null here this should be refactored and
tested in another patch.
Line 177: addStorageDomainStatusIllegalMessage();
Line 178: return true;
Line 179: }
Line 180: return false;
....................................................
File
backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/storage/StorageDomainCommandBaseTest.java
Line 96: public void checkStorageDomainNotEqualWithStatusActive() {
Line 97: setStorageDomainStatus(StorageDomainStatus.Active);
Line 98:
assertFalse(cmd.checkStorageDomainStatusNotEqual(StorageDomainStatus.Active));
Line 99: List<String> messages =
cmd.getReturnValue().getCanDoActionMessages();
Line 100: assertEquals(messages.size(), 0);
(active ne active) == false.
That's fine.
Line 101: }
Line 102:
Line 103: @Test
Line 104: public void checkStorageDomainNotEqualWithNonActiveStatus() {
--
To view, visit http://gerrit.ovirt.org/21320
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ibe8ad96a5bd40adb56b7a63c4ae5ef75a550e5b2
Gerrit-PatchSet: 6
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Vered Volansky <vvola...@redhat.com>
Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com>
Gerrit-Reviewer: Cheryn Tan <cheryn...@redhat.com>
Gerrit-Reviewer: Daniel Erez <de...@redhat.com>
Gerrit-Reviewer: Liron Ar <lara...@redhat.com>
Gerrit-Reviewer: Michael Pasternak <mpast...@redhat.com>
Gerrit-Reviewer: Sergey Gotliv <sgot...@redhat.com>
Gerrit-Reviewer: Vered Volansky <vvola...@redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
