Vered Volansky has posted comments on this change.
Change subject: core: Storage activation error fix
......................................................................
Patch Set 4:
(1 comment)
Allon, I changed one vdcBllMessage because I refactored another to look like
it. This caused usage throughout the system to use the new message that also
expects status, without actually sending the status. Easiest thing for now will
be to bring back the redundant message without the status expectation. Ugly,
but not for this bug's scope.
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/StorageDomainCommandBase.java
Line 172: return valid;
Line 173: }
Line 174:
Line 175: protected boolean
checkStorageDomainStatusNotEqual(StorageDomainStatus status) {
Line 176: if (getStorageDomainStatus() != null &&
getStorageDomainStatus() != status) {
Look inside! when getStorageDomain returns null. Looks too cautious to me, but
I followed code elsewhere.
Line 177: addStorageDomainStatusIllegalMessage();
Line 178: return true;
Line 179: }
Line 180: return false;
--
To view, visit http://gerrit.ovirt.org/21320
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ibe8ad96a5bd40adb56b7a63c4ae5ef75a550e5b2
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Vered Volansky <vvola...@redhat.com>
Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com>
Gerrit-Reviewer: Cheryn Tan <cheryn...@redhat.com>
Gerrit-Reviewer: Daniel Erez <de...@redhat.com>
Gerrit-Reviewer: Liron Ar <lara...@redhat.com>
Gerrit-Reviewer: Michael Pasternak <mpast...@redhat.com>
Gerrit-Reviewer: Sergey Gotliv <sgot...@redhat.com>
Gerrit-Reviewer: Vered Volansky <vvola...@redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
