Einav Cohen has posted comments on this change. Change subject: userportal, webadmin: refactor: add model attribute for help tags ......................................................................
Patch Set 6: > > No, this is bad Java. We shouldn't do bad Java for ease of grep purposes. > This exactly what we need to do, as these tags are MEANT to be scanned by > external tool to produce the index. I agree; once we decided to treat these files as text files (as far as the parser is concerned), the Java rules aren't really relevant/applicable here - we should make that as easy to consume by the tool as possible. let's go back to the way that it was in here, for example: http://gerrit.ovirt.org/#/c/21052/3/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/clusters/ClusterGlusterHookListModel.java thanks. -- To view, visit http://gerrit.ovirt.org/21052 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia4074fcc2ecfcbdd2ea6c0855d92f2aa4bd26a5b Gerrit-PatchSet: 6 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Greg Sheremeta <gsher...@redhat.com> Gerrit-Reviewer: Alexander Wels <aw...@redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alo...@redhat.com> Gerrit-Reviewer: Einav Cohen <eco...@redhat.com> Gerrit-Reviewer: Greg Sheremeta <gsher...@redhat.com> Gerrit-Reviewer: Vojtech Szocs <vsz...@redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
