Alon Bar-Lev has posted comments on this change.
Change subject: userportal, webadmin: refactor: add model attribute for help
tags
......................................................................
Patch Set 6: Code-Review-1
Just to emphasis my other comments.
The setHelpTag should contain two static strings to allow easy use of code
scanning tool.
For example:
setHelpTag("tag-name", "this is an example")
The first is a tag, the second is useless help string that you want to add.
The tag is for now the same as the setTag() content but from this point on it
is completely independent as help tag and location tag are two separate things.
The only reason why we keep using the existing tag is because there are some
claims that it is too complex to modify it into structured format at this point
in time.
--
To view, visit http://gerrit.ovirt.org/21052
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia4074fcc2ecfcbdd2ea6c0855d92f2aa4bd26a5b
Gerrit-PatchSet: 6
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Greg Sheremeta <gsher...@redhat.com>
Gerrit-Reviewer: Alexander Wels <aw...@redhat.com>
Gerrit-Reviewer: Alon Bar-Lev <alo...@redhat.com>
Gerrit-Reviewer: Einav Cohen <eco...@redhat.com>
Gerrit-Reviewer: Greg Sheremeta <gsher...@redhat.com>
Gerrit-Reviewer: Vojtech Szocs <vsz...@redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
