Einav Cohen has posted comments on this change. Change subject: userportal, webadmin: refactor: add model attribute for help tags ......................................................................
Patch Set 7: I now understood what is Alon's concern: >From one of my previous comments: """ ... I also don't want to give them different "structured format strings", since this will result in multiple "entries" on the in the dialog-to-docs mapping for literally the same dialog, which is wrong. ... """ >From the developer's perspective, there shouldn't be "two instances of the >same dialog" - the decision whether two instances are of the same dialog or >not should be the documentation guy decision. Therefore, each dialog instance >should have a unique identifier, and it might as well be descriptive, assuming >we want to maintain only one property per dialog instance, and not multiple. -- To view, visit http://gerrit.ovirt.org/21052 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia4074fcc2ecfcbdd2ea6c0855d92f2aa4bd26a5b Gerrit-PatchSet: 7 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Greg Sheremeta <gsher...@redhat.com> Gerrit-Reviewer: Alexander Wels <aw...@redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alo...@redhat.com> Gerrit-Reviewer: Einav Cohen <eco...@redhat.com> Gerrit-Reviewer: Greg Sheremeta <gsher...@redhat.com> Gerrit-Reviewer: Vojtech Szocs <vsz...@redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
