Greg Sheremeta has posted comments on this change. Change subject: engine: create tool to scan source code for help tags ......................................................................
Patch Set 4: Alon, please try to be helpful and address this point: ??? It's perfectly valid Java. Someone could easily write that or similar. The simple fact is that you cannot guarantee the helpTag value will be hardcoded any more than I can guarantee the helpTag value will appear on the previous line. Do you concede this point? Just saying "-1, no -2" doesn't help move this along. -- To view, visit http://gerrit.ovirt.org/21390 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I70a92fd49a00fe7c235d7bc201218a7119dfa425 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Greg Sheremeta <gsher...@redhat.com> Gerrit-Reviewer: Alexander Wels <aw...@redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alo...@redhat.com> Gerrit-Reviewer: Einav Cohen <eco...@redhat.com> Gerrit-Reviewer: Greg Sheremeta <gsher...@redhat.com> Gerrit-Reviewer: Vojtech Szocs <vsz...@redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
