Greg Sheremeta has posted comments on this change. Change subject: engine: create tool to scan source code for help tags ......................................................................
Patch Set 4: But humans are writing the code. What if someone changes the hardcoded help tag to be a variable? String helpTag = "add_vm"; ... model.setHelpTag(helpTag, comment); // parser fail It can't be perfect! -- To view, visit http://gerrit.ovirt.org/21390 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I70a92fd49a00fe7c235d7bc201218a7119dfa425 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Greg Sheremeta <gsher...@redhat.com> Gerrit-Reviewer: Alexander Wels <aw...@redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alo...@redhat.com> Gerrit-Reviewer: Einav Cohen <eco...@redhat.com> Gerrit-Reviewer: Greg Sheremeta <gsher...@redhat.com> Gerrit-Reviewer: Vojtech Szocs <vsz...@redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
