Alon Bar-Lev has posted comments on this change.
Change subject: engine: create tool to scan source code for help tags
......................................................................
Patch Set 3:
(2 comments)
....................................................
File build/doctag.py
Line 85: helpTag = m.group("helpTag")
Line 86: helpComment = m.group("helpComment")
Line 87: if helpTag in tags:
Line 88: if tags[helpTag] != helpComment:
Line 89: sys.stderr.write("Warning:
detected help tag with multiple uses and different comments: %s ['%s' !=
'%s'])\n" \
this file does not pass pep8
Line 90: % (helpTag,
helpComment, tags[helpTag]));
Line 91: else:
Line 92: tags[helpTag] = helpComment
Line 93: prev_line = line
Line 89: sys.stderr.write("Warning:
detected help tag with multiple uses and different comments: %s ['%s' !=
'%s'])\n" \
Line 90: % (helpTag,
helpComment, tags[helpTag]));
Line 91: else:
Line 92: tags[helpTag] = helpComment
Line 93: prev_line = line
relaying on previous line and is wrong, you should relay on tokens not lines,
so that:
x y
and
x
y
and
x
z y
and such will be accepted, we are talking about human writing the code.
this is why it was wrong to separate the tags and not add parameter to the
current setHashName or hardcode the hash into the setHelpTag
Line 94: return tags
Line 95:
Line 96:
Line 97: def produceTemplate(tags, out, format=FORMAT_JSON):
--
To view, visit http://gerrit.ovirt.org/21390
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I70a92fd49a00fe7c235d7bc201218a7119dfa425
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Greg Sheremeta <gsher...@redhat.com>
Gerrit-Reviewer: Alexander Wels <aw...@redhat.com>
Gerrit-Reviewer: Alon Bar-Lev <alo...@redhat.com>
Gerrit-Reviewer: Einav Cohen <eco...@redhat.com>
Gerrit-Reviewer: Greg Sheremeta <gsher...@redhat.com>
Gerrit-Reviewer: Vojtech Szocs <vsz...@redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
