Sergey Gotliv has posted comments on this change.
Change subject: core: Storage activation error fix
......................................................................
Patch Set 3:
(1 comment)
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/ActivateStorageDomainCommand.java
Line 140:
Line 141: private boolean storageDomainStatusIsValid() {
Line 142: if (getStorageDomainStatus() == StorageDomainStatus.Active) {
Line 143: return
failCanDoAction(VdcBllMessages.ACTION_TYPE_FAILED_STORAGE_DOMAIN_ALREADY_ACTIVE);
Line 144: }
Liron,
Personally, I wouldn't apply code reuse rules on error messages.
But if you sure that you can create the same error message for all statuses
without changing a word "is ILLEGAL", "on maintenance", "is already active" ...
and it won't make these messages too "machinery" I will vote for that.
Line 145:
Line 146: if (isInternalExecution()) {
Line 147: return
checkStorageDomainStatus(StorageDomainStatus.InActive,
StorageDomainStatus.Unknown,
Line 148: StorageDomainStatus.Locked,
StorageDomainStatus.Maintenance);
--
To view, visit http://gerrit.ovirt.org/21320
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ibe8ad96a5bd40adb56b7a63c4ae5ef75a550e5b2
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Vered Volansky <vvola...@redhat.com>
Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com>
Gerrit-Reviewer: Cheryn Tan <cheryn...@redhat.com>
Gerrit-Reviewer: Daniel Erez <de...@redhat.com>
Gerrit-Reviewer: Liron Ar <lara...@redhat.com>
Gerrit-Reviewer: Michael Pasternak <mpast...@redhat.com>
Gerrit-Reviewer: Sergey Gotliv <sgot...@redhat.com>
Gerrit-Reviewer: Vered Volansky <vvola...@redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
