Liron Ar has posted comments on this change. Change subject: engine: Adding new test for read only disk feature. ......................................................................
Patch Set 2: (1 comment) .................................................... File backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/UpdateVmDiskCommandTest.java Line 295: when(diskDao.get(diskImageGuid)).thenReturn(createDiskImage()); Line 296: Line 297: initializeCommand(parameters); Line 298: command.executeVmCommand(); Line 299: 1. what about creating the device/mocking vmdevicedao? 2. when you do, please add assertion that the device.readonly is false also. 3. please add verify() that shouldUpdateReadOnly() is being called. Line 300: assertFalse(command.shouldUpdateReadOnly()); Line 301: verify(vmDeviceDAO, never()).update(any(VmDevice.class)); Line 302: } Line 303: -- To view, visit http://gerrit.ovirt.org/21241 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I4d490eda5df4387ceedf4e0acd6ccd980249b797 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Sergey Gotliv <sgot...@redhat.com> Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com> Gerrit-Reviewer: Liron Ar <lara...@redhat.com> Gerrit-Reviewer: Sergey Gotliv <sgot...@redhat.com> Gerrit-Reviewer: Tal Nisan <tni...@redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
