Liron Ar has posted comments on this change. Change subject: engine: Adding new test for read only disk feature. ......................................................................
Patch Set 1: (1 comment) .................................................... File backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/UpdateVmDiskCommandTest.java Line 293: parameters.getDiskInfo().setReadOnly(false); Line 294: Line 295: DiskImage diskFromDb = createDiskImage(); Line 296: diskFromDb.setReadOnly(false); Line 297: when(diskDao.get(diskImageGuid)).thenReturn(diskFromDb); 1. you compare with vmDevice in the command. 2. please also use assert to check the return value shouldUpdateReadOnly(). thanks! Line 298: Line 299: initializeCommand(parameters); Line 300: command.executeVmCommand(); Line 301: -- To view, visit http://gerrit.ovirt.org/21241 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I4d490eda5df4387ceedf4e0acd6ccd980249b797 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Sergey Gotliv <sgot...@redhat.com> Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com> Gerrit-Reviewer: Liron Ar <lara...@redhat.com> Gerrit-Reviewer: Sergey Gotliv <sgot...@redhat.com> Gerrit-Reviewer: Tal Nisan <tni...@redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
