[Engine-patches] Change in ovirt-engine[master]: engine: Adding new test for read only disk feature.

[sgotliv]

Sergey Gotliv has uploaded a new change for review.

Change subject: engine: Adding new test for read only disk feature.
......................................................................

engine: Adding new test for read only disk feature.

Change-Id: I4d490eda5df4387ceedf4e0acd6ccd980249b797
Signed-off-by: Sergey Gotliv <sgot...@redhat.com>
---
M 
backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/UpdateVmDiskCommandTest.java
1 file changed, 16 insertions(+), 0 deletions(-)


  git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/41/21241/1

diff --git 
a/backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/UpdateVmDiskCommandTest.java
 
b/backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/UpdateVmDiskCommandTest.java
index 343edd5..b39cf34 100644
--- 
a/backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/UpdateVmDiskCommandTest.java
+++ 
b/backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/UpdateVmDiskCommandTest.java
@@ -7,6 +7,7 @@
 import static org.mockito.Mockito.doNothing;
 import static org.mockito.Mockito.doReturn;
 import static org.mockito.Mockito.mock;
+import static org.mockito.Mockito.never;
 import static org.mockito.Mockito.spy;
 import static org.mockito.Mockito.times;
 import static org.mockito.Mockito.verify;
@@ -286,6 +287,21 @@
         verify(vmDeviceDAO, times(1)).update(device);
     }
 
+    @Test
+    public void testDoNotUpdateDeviceWhenReadOnlyIsNotChanged() {
+        final UpdateVmDiskParameters parameters = createParameters();
+        parameters.getDiskInfo().setReadOnly(false);
+
+        DiskImage diskFromDb = createDiskImage();
+        diskFromDb.setReadOnly(false);
+        when(diskDao.get(diskImageGuid)).thenReturn(diskFromDb);
+
+        initializeCommand(parameters);
+        command.executeVmCommand();
+
+        verify(vmDeviceDAO, never()).update(any(VmDevice.class));
+    }
+
     private void initializeCommand(UpdateVmDiskParameters params) {
         initializeCommand(params, 
Collections.singletonList(createVmStatusDown()));
     }


-- 
To view, visit http://gerrit.ovirt.org/21241
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I4d490eda5df4387ceedf4e0acd6ccd980249b797
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Sergey Gotliv <sgot...@redhat.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches