Yedidyah Bar David has posted comments on this change. Change subject: packaging: setup: update firewall for all services ......................................................................
Patch Set 3: > For specific case in which you modify component, well, ok, but... for generic > case that every upgrade override the firewall? this is invalid. While I might agree, this is (again) irrelevant for this change. This change merely changes the conditions under which we already add stuff to osetupcons.NetEnv.FIREWALLD_SERVICES . Do you have a problem with these conditions? If we later decide e.g. to ignore osetupcons.NetEnv.FIREWALLD_SERVICES altogether on upgrades, to ignore it if using iptables, whatever, fine. We'll discuss this then. -- To view, visit http://gerrit.ovirt.org/20737 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: If3c1a634b2e8539ebd604205b5487290c8d8a1a9 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yedidyah Bar David <d...@redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alo...@redhat.com> Gerrit-Reviewer: Ofer Schreiber <oschr...@redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbona...@redhat.com> Gerrit-Reviewer: Yedidyah Bar David <d...@redhat.com> Gerrit-HasComments: No _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
