Tomas Jelinek has posted comments on this change.
Change subject: userportal: error flow of RDP RdpPluginImpl broken
......................................................................
Patch Set 1:
(2 comments)
....................................................
File
frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/uicommon/AbstractRdp.java
Line 31: }
Line 32:
Line 33: public String getUserPassword() {
Line 34: String password = Frontend.getInstance().getLoginPassword();
Line 35: return password != null ? password : ""; //$NON-NLS-1$
It will work - just the SSO will not. But the fact that after autologin the SSO
does not work for RDP is a known issue (and we don't have a secure solution for
that). The problem here is that if we return null, the MsRdpClient fails on NPE
so you can not connect to the VM. If we return an empty string you can connect
to the VM, just need to log in manually which is much better.
Line 36: }
Line 37:
Line 38: public String getUserDomainController() {
Line 39: return Frontend.getInstance().getLoggedInUser().getDomain();
....................................................
File
frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/uicommon/RdpPluginImpl.java
Line 125
Line 126
Line 127
Line 128
Line 129
Because IE fails if we do it here. It has to be done outside of the context of
the MsRdpClient's call (and it is done in the line 99 - so there will be no
stale objects).
This has been reported once and fixed here (http://gerrit.ovirt.org/#/c/14223/)
but during some refactorings it accidentally found it's way back to the code.
--
To view, visit http://gerrit.ovirt.org/20952
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I85fc3b32c4f544f23864db2aefa5ebcd4d896b75
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Tomas Jelinek <tjeli...@redhat.com>
Gerrit-Reviewer: Daniel Erez <de...@redhat.com>
Gerrit-Reviewer: Frank Kobzik <fkob...@redhat.com>
Gerrit-Reviewer: Gilad Chaplik <gchap...@redhat.com>
Gerrit-Reviewer: Tomas Jelinek <tjeli...@redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
