Daniel Erez has posted comments on this change.
Change subject: userportal: error flow of RDP RdpPluginImpl broken
......................................................................
Patch Set 1:
(2 comments)
....................................................
File
frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/uicommon/AbstractRdp.java
Line 31: }
Line 32:
Line 33: public String getUserPassword() {
Line 34: String password = Frontend.getInstance().getLoginPassword();
Line 35: return password != null ? password : ""; //$NON-NLS-1$
so the connection still won't work after autologin?
Line 36: }
Line 37:
Line 38: public String getUserDomainController() {
Line 39: return Frontend.getInstance().getLoggedInUser().getDomain();
....................................................
File
frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/uicommon/RdpPluginImpl.java
Line 125
Line 126
Line 127
Line 128
Line 129
why not removing the stale object from the body?
--
To view, visit http://gerrit.ovirt.org/20952
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I85fc3b32c4f544f23864db2aefa5ebcd4d896b75
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Tomas Jelinek <tjeli...@redhat.com>
Gerrit-Reviewer: Daniel Erez <de...@redhat.com>
Gerrit-Reviewer: Frank Kobzik <fkob...@redhat.com>
Gerrit-Reviewer: Gilad Chaplik <gchap...@redhat.com>
Gerrit-Reviewer: Tomas Jelinek <tjeli...@redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
