Alissa Bonas has posted comments on this change.
Change subject: core: allow identical path for different local domains
......................................................................
Patch Set 4:
(1 comment)
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/StorageServerConnectionCommandBase.java
Line 79: connections =
getStorageConnDao().getAllForConnection(connection);
Line 80: }
Line 81:
Line 82: boolean isDuplicateConnExists = (connections.size() > 1
Line 83: || (connections.size() == 1 &&
connections.get(0).getconnection().equalsIgnoreCase(connection.getconnection())));
that condition will be always true, because the connections were extracted
based on that field, so you won't get here something that has a different value
in that field...
and I think that the previous condition was ok because it served both create
new connection and update connection.
the condition that checks if 1 connection returned - in case of update, we have
connection id for the input, so the condition evaluation is ok. in case of new
connection creation, if something already exists in db, and we don't have id,
then it also will return false because empty id doesn't equal the id from db.
Line 84: return isDuplicateConnExists;
Line 85: }
Line 86:
Line 87: protected boolean
checkIsConnectionFieldEmpty(StorageServerConnections connection) {
--
To view, visit http://gerrit.ovirt.org/20886
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I4628d7fa442b959d5582e44386f31518b98852e7
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Daniel Erez <de...@redhat.com>
Gerrit-Reviewer: Alissa Bonas <abo...@redhat.com>
Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com>
Gerrit-Reviewer: Daniel Erez <de...@redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
