Daniel Erez has posted comments on this change. Change subject: core: allow identical path for different local domains ......................................................................
Patch Set 6: (1 comment) .................................................... File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/StorageServerConnectionCommandBase.java Line 54: return getStorageDomainDao().getAllByConnectionId(Guid.createGuidFromString(connectionId)); Line 55: } Line 56: Line 57: protected Guid getStoragePoolIdByFileConnectionId(String connectionId) { Line 58: List<StorageDomain> storageDomains = getStorageDomainsByConnId(connectionId); I've already changed this method name the indicate it explicitly :) Will add javadoc on rebase. Line 59: if (storageDomains.isEmpty()) { Line 60: return null; Line 61: } Line 62: -- To view, visit http://gerrit.ovirt.org/20886 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I4628d7fa442b959d5582e44386f31518b98852e7 Gerrit-PatchSet: 6 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Daniel Erez <de...@redhat.com> Gerrit-Reviewer: Alissa Bonas <abo...@redhat.com> Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com> Gerrit-Reviewer: Daniel Erez <de...@redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches