Alissa Bonas has posted comments on this change.
Change subject: core: allow identical path for different local domains
......................................................................
Patch Set 2:
(1 comment)
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/StorageServerConnectionCommandBase.java
Line 64:
Line 65: protected boolean
isConnWithSameDetailsExists(StorageServerConnections connection) {
Line 66: List<StorageServerConnections> connections = null;
Line 67: if (connection.getstorage_type() == StorageType.LOCALFS) {
Line 68: Guid storagePoolId =
getStoragePoolIdByConnId(connection.getid());
connection id is empty at this point because clients are not supposed to send
conn id, it is supposed to be generated by the server, and since duplication
check is done as part of canDo, the id hasn't been generated yet, so probably
this check as it's written right now will not do the work.
Line 69: connections = storagePoolId == null ?
Collections.<StorageServerConnections> emptyList() :
Line 70:
getStorageConnDao().getAllConnectableStorageSeverConnection(storagePoolId);
Line 71: }
Line 72: else if (connection.getstorage_type().isFileDomain()) {
--
To view, visit http://gerrit.ovirt.org/20886
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I4628d7fa442b959d5582e44386f31518b98852e7
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Daniel Erez <de...@redhat.com>
Gerrit-Reviewer: Alissa Bonas <abo...@redhat.com>
Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
