Kanagaraj M has posted comments on this change.
Change subject: gluster: update cluster 'comment' when new host found
......................................................................
Patch Set 5:
(3 comments)
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/GlusterSyncJob.java
Line 57: private static final GlusterSyncJob instance = new
GlusterSyncJob();
Line 58:
Line 59: public static final String ACTION_REQUIRED_NEW_SERVERS_FOUND_MSG =
Line 60: "ACTION REQUIRED: Some new hosts are found in the cluster";
Line 61:
do you mean this needs to be translated?
I don't think this message should localized. If we do so, it will be difficult
to clear the msg when there are no new hosts in the cluster.
Line 62: private GlusterSyncJob() {
Line 63: }
Line 64:
Line 65: public static GlusterSyncJob getInstance() {
Line 172: private boolean hasNewServers(VDSGroup cluster, List<VDS>
existingServers, List<GlusterServerInfo> fetchedServers) {
Line 173: if
(GlusterFeatureSupported.glusterHostUuidSupported(cluster.getcompatibility_version()))
{
Line 174: for (GlusterServerInfo fetchedServer : fetchedServers) {
Line 175: GlusterServer glusterServer =
getGlusterServerDao().getByGlusterServerUuid(fetchedServer.getUuid());
Line 176: if (glusterServer == null ||
getVdsDao().get(glusterServer.getId()) == null) {
not required, will remove it
Line 177: return true;
Line 178: }
Line 179: }
Line 180: }
....................................................
File
backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/gluster/GlusterSyncJobTest.java
Line 100: private static final String OPTION_VALUE_OFF = "off";
Line 101: private static final Guid SERVER_ID_1 = new
Guid("23f6d691-5dfb-472b-86dc-9e1d2d3c18f3");
Line 102: private static final Guid SERVER_ID_2 = new
Guid("2001751e-549b-4e7a-aff6-32d36856c125");
Line 103: private static final Guid SERVER_ID_3 = new
Guid("2001751e-549b-4e7a-aff6-32d36856c126");
Line 104: private static final Guid SERVER_ID_4 = new
Guid("2001751e-549b-4e7a-aff6-32d36856c127");
No, this is not used for verification.
Only verifying the comment field of the cluster is engough
Line 105: private static final Guid GLUSTER_SERVER_UUID_1 = new
Guid("24f4d494-5dfb-472b-86dc-9e1d2d3c18f3");
Line 106: private static final String SERVER_NAME_1 = "srvr1";
Line 107: private static final String SERVER_NAME_2 = "srvr2";
Line 108: private static final String SERVER_NAME_3 = "srvr3";
--
To view, visit http://gerrit.ovirt.org/20755
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I07c30ae9d7381a56edc753fdbfdb439465ffe6b7
Gerrit-PatchSet: 5
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Kanagaraj M <kmayi...@redhat.com>
Gerrit-Reviewer: Itamar Heim <ih...@redhat.com>
Gerrit-Reviewer: Kanagaraj M <kmayi...@redhat.com>
Gerrit-Reviewer: Ramesh N <rnach...@redhat.com>
Gerrit-Reviewer: Sahina Bose <sab...@redhat.com>
Gerrit-Reviewer: Shubhendu Tripathi <shtri...@redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
