Gilad Chaplik has uploaded a new change for review. Change subject: webadmin: wrong memory overcommit unit ......................................................................
webadmin: wrong memory overcommit unit in cluster general info sub tab, Max Memory Over Commitment unit is MB, and should be % Change-Id: Ie572092251bc5d5a87f9734f18194389cf1fbe29 Bug-Url: https://bugzilla.redhat.com/1021326 Signed-off-by: Gilad Chaplik <gchap...@redhat.com> --- M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/tab/cluster/ClusterGeneralModelForm.java 1 file changed, 3 insertions(+), 3 deletions(-) git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/76/20976/1 diff --git a/frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/tab/cluster/ClusterGeneralModelForm.java b/frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/tab/cluster/ClusterGeneralModelForm.java index a66a0a9..6aaa9ed 100644 --- a/frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/tab/cluster/ClusterGeneralModelForm.java +++ b/frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/tab/cluster/ClusterGeneralModelForm.java @@ -6,13 +6,13 @@ import org.ovirt.engine.ui.common.widget.form.FormItem.DefaultValueCondition; import org.ovirt.engine.ui.common.widget.label.BooleanLabel; import org.ovirt.engine.ui.common.widget.label.ClusterTypeLabel; -import org.ovirt.engine.ui.common.widget.label.MemorySizeLabel; import org.ovirt.engine.ui.common.widget.label.ResiliencePolicyLabel; import org.ovirt.engine.ui.common.widget.label.TextBoxLabel; import org.ovirt.engine.ui.common.widget.uicommon.AbstractModelBoundFormWidget; import org.ovirt.engine.ui.uicommonweb.models.ApplicationModeHelper; import org.ovirt.engine.ui.uicommonweb.models.clusters.ClusterGeneralModel; import org.ovirt.engine.ui.webadmin.ApplicationConstants; +import org.ovirt.engine.ui.webadmin.widget.label.PercentLabel; import com.google.gwt.core.client.GWT; import com.google.gwt.editor.client.SimpleBeanEditorDriver; @@ -27,7 +27,7 @@ TextBoxLabel dataCenterName = new TextBoxLabel(); TextBoxLabel cpuName = new TextBoxLabel(); BooleanLabel cpuThreads; - MemorySizeLabel<Integer> memoryOverCommit; + PercentLabel<Integer> memoryOverCommit; ResiliencePolicyLabel resiliencePolicy; ClusterTypeLabel clusterType; TextBoxLabel noOfVolumesTotal = new TextBoxLabel(); @@ -42,7 +42,7 @@ final ApplicationConstants constants) { super(modelProvider, 3, 5); cpuThreads = new BooleanLabel(constants.yes(), constants.no()); - memoryOverCommit = new MemorySizeLabel<Integer>(constants); + memoryOverCommit = new PercentLabel<Integer>(); resiliencePolicy = new ResiliencePolicyLabel(constants); clusterType = new ClusterTypeLabel(constants); -- To view, visit http://gerrit.ovirt.org/20976 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: Ie572092251bc5d5a87f9734f18194389cf1fbe29 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.3 Gerrit-Owner: Gilad Chaplik <gchap...@redhat.com> _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
