Omer Frenkel has posted comments on this change.
Change subject: new feature: Vm Payload
......................................................................
Patch Set 9: (2 inline comments)
some minor comments
....................................................
File backend/manager/dbscripts/upgrade/pre_upgrade/config.sql
Line 205: select fn_db_add_config_value('PayloadSize','8192','general');
need to check if we want users to be able to edit this,
if so, add it to engine-config.properties file as well
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RunVmCommand.java
Line 846: // check for Vm Payload
i think this code should be extracted for re-use, as it is used again later.
--
To view, visit http://gerrit.ovirt.org/3243
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I4c2820acfa8ec0f736e5fe0ce192e84df0915f12
Gerrit-PatchSet: 9
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Shahar Havivi <shav...@redhat.com>
Gerrit-Reviewer: Daniel Erez <de...@redhat.com>
Gerrit-Reviewer: Eli Mesika <emes...@redhat.com>
Gerrit-Reviewer: Omer Frenkel <ofren...@redhat.com>
Gerrit-Reviewer: Shahar Havivi <shav...@redhat.com>
Gerrit-Reviewer: Yaniv Kaul <yk...@redhat.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
