Eli Mesika has posted comments on this change.

Change subject: new feature: Vm Payload
......................................................................


Patch Set 8: (1 inline comment)

....................................................
File backend/manager/dbscripts/upgrade/pre_upgrade/config.sql
Line 366: select fn_db_add_config_value('PayloadSize','8192','general');
Shahar, can you move this line to its place, I think  that it is good to have 
this file ordered by key per section for easy navigation and also wrote that in 
the file header : "In each section (except simple/function sections), entries 
are ordered by key,
please keep this when modifing this file."

If you think this is redundant please let me know ...

--
To view, visit http://gerrit.ovirt.org/3243
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I4c2820acfa8ec0f736e5fe0ce192e84df0915f12
Gerrit-PatchSet: 8
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Shahar Havivi <shav...@redhat.com>
Gerrit-Reviewer: Daniel Erez <de...@redhat.com>
Gerrit-Reviewer: Eli Mesika <emes...@redhat.com>
Gerrit-Reviewer: Omer Frenkel <ofren...@redhat.com>
Gerrit-Reviewer: Shahar Havivi <shav...@redhat.com>
Gerrit-Reviewer: Yaniv Kaul <yk...@redhat.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to